[RNE Rewrite] feat: support offset and length options in Tensor.copyTo#1287
Merged
Conversation
15 tasks
msluszniak
reviewed
Jun 29, 2026
msluszniak
requested changes
Jun 29, 2026
msluszniak
left a comment
Member
There was a problem hiding this comment.
Demo apps with semantic segmentation and style transfer does not work with this change, I got error: Value is undefined, expected an Object. Other models, namely object detection, kepoint detection and classification works correctly.
Contributor
Author
It works fine for me, did you do a clean rebuild? |
Member
|
Yeah, stale caches. |
msluszniak
approved these changes
Jun 29, 2026
msluszniak
added a commit
that referenced
this pull request
Jun 29, 2026
## Description Adds instance segmentation task pipeline and corresponding example screen in computer-vision app. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [ ] Bug fix (change which fixes an issue) - [x] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [ ] Android ### Testing instructions - [ ] Build computer vision app on both Android and iOS - [ ] Test the newly added instance segmentation screen - [ ] Check the modified HF repos: - https://huggingface.co/software-mansion/react-native-executorch-fast-sam - https://huggingface.co/software-mansion/react-native-executorch-rfdetr-nano-segmentation - https://huggingface.co/software-mansion/react-native-executorch-fast-sam ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues Closes #1238 ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes Can be merged only after #1287 --------- Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends Tensor.copyTo() to support optional offset and length configuration parameters. This allows copying a slice/sub region of a source tensor into a destination tensor, which is useful for tasks such as extracting rows from a batched tensor.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes